Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/snap: fix the order of positional parameters in help output #8624

Merged
merged 1 commit into from May 8, 2020
Merged

cmd/snap: fix the order of positional parameters in help output #8624

merged 1 commit into from May 8, 2020

Conversation

bboozzoo
Copy link
Collaborator

@bboozzoo bboozzoo commented May 8, 2020

The order of parameters expected in the code for restore (and other snapshot
related commands) is . However, the order of id/snap was reversed in
snap restore --help output. Originally reported in the forum [1].

  1. https://forum.snapcraft.io/t/17291

@bboozzoo
cmd/snap: fix the order of positional parameters in help output
8b09bea 
The order of parameters expected in the code for restore (and other snapshot
related commands) is <id> <snap>. However, the order of id/snap was reversed in
`snap restore --help` output. Originally reported in the forum [1].

1. https://forum.snapcraft.io/t/17291

Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
@bboozzoo bboozzoo added Simple 😃 A small PR which can be reviewed quickly Skip spread Indicate that spread job should not run labels May 8, 2020
stolowski
stolowski approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@stolowski stolowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@bboozzoo bboozzoo added this to the 2.45 milestone May 8, 2020
@anonymouse64
Copy link
Member

Failure here seems to be network/apt related:

2020-05-08T08:28:32.0322948Z Err:6 http://us-east1.gce.archive.ubuntu.com/ubuntu focal-updates/main amd64 Packages
2020-05-08T08:28:32.0323087Z   Hash Sum mismatch
2020-05-08T08:28:32.0323180Z   Hashes of expected file:
2020-05-08T08:28:32.0323396Z    - Filesize:84324 [weak]
2020-05-08T08:28:32.0323804Z    - SHA256:dd6234daf5deb90c2f5d5fec1ea076379919b5fcf191ab0cf9374ce8d29bcebd
2020-05-08T08:28:32.0324091Z    - SHA1:c6ba047086333540ffd315d201c997dc2d4c009d [weak]
2020-05-08T08:28:32.0324350Z    - MD5Sum:86381d6cb11f9a6f657c38bd210c73c0 [weak]
2020-05-08T08:28:32.0324436Z   Hashes of received file:
2020-05-08T08:28:32.0324724Z    - SHA256:445b58aadd489c62ec98d38d96f51fc36b14940255606ce04d22e12ed3bfa2f5
2020-05-08T08:28:32.0325006Z    - SHA1:1084ff0ec91953d051609f55045f1775b88fe496 [weak]
2020-05-08T08:28:32.0325251Z    - MD5Sum:5d09fb2af74be1a9c701e9234cf81627 [weak]
2020-05-08T08:28:32.0325791Z    - Filesize:84324 [weak]
2020-05-08T08:28:32.0326011Z   Last modification reported: Fri, 08 May 2020 06:55:00 +0000
2020-05-08T08:28:32.0326116Z   Release file created at: Fri, 08 May 2020 07:55:23 +0000
2020-05-08T08:28:32.0326454Z Get:11 http://us-east1.gce.archive.ubuntu.com/ubuntu focal-updates/universe amd64 Packages [27.2 kB]
2020-05-08T08:28:32.0326811Z Err:11 http://us-east1.gce.archive.ubuntu.com/ubuntu focal-updates/universe amd64 Packages
2020-05-08T08:28:32.0326943Z   
2020-05-08T08:28:32.0327263Z Get:14 http://us-east1.gce.archive.ubuntu.com/ubuntu focal-backports/universe amd64 Packages [2792 B]
2020-05-08T08:28:32.0327624Z Get:15 http://us-east1.gce.archive.ubuntu.com/ubuntu focal-backports/universe Translation-en [1280 B]
2020-05-08T08:28:32.0327990Z Get:16 http://us-east1.gce.archive.ubuntu.com/ubuntu focal-backports/universe amd64 c-n-f Metadata [188 B]
2020-05-08T08:28:32.0328342Z Get:17 http://security.ubuntu.com/ubuntu focal-security/main amd64 Packages [50.1 kB]
2020-05-08T08:28:32.0328683Z Get:18 http://security.ubuntu.com/ubuntu focal-security/main Translation-en [18.5 kB]
2020-05-08T08:28:32.0329019Z Get:19 http://security.ubuntu.com/ubuntu focal-security/main amd64 c-n-f Metadata [1352 B]
2020-05-08T08:28:32.0329351Z Get:20 http://security.ubuntu.com/ubuntu focal-security/restricted amd64 Packages [4180 B]
2020-05-08T08:28:32.0329669Z Get:21 http://security.ubuntu.com/ubuntu focal-security/restricted Translation-en [1360 B]
2020-05-08T08:28:32.0329997Z Get:22 http://security.ubuntu.com/ubuntu focal-security/universe amd64 Packages [7548 B]
2020-05-08T08:28:32.0330331Z Get:23 http://security.ubuntu.com/ubuntu focal-security/universe Translation-en [5636 B]
2020-05-08T08:28:32.0330662Z Get:24 http://security.ubuntu.com/ubuntu focal-security/universe amd64 c-n-f Metadata [608 B]
2020-05-08T08:28:32.0330786Z Fetched 542 kB in 2s (348 kB/s)
2020-05-08T08:28:32.0330866Z Reading package lists...
2020-05-08T08:28:32.0331235Z E: Failed to fetch http://us-east1.gce.archive.ubuntu.com/ubuntu/dists/focal-updates/main/binary-amd64/Packages.xz  Hash Sum mismatch
2020-05-08T08:28:32.0331385Z    Hashes of expected file:
2020-05-08T08:28:32.0331660Z     - Filesize:84324 [weak]
2020-05-08T08:28:32.0331954Z     - SHA256:dd6234daf5deb90c2f5d5fec1ea076379919b5fcf191ab0cf9374ce8d29bcebd
2020-05-08T08:28:32.0332218Z     - SHA1:c6ba047086333540ffd315d201c997dc2d4c009d [weak]
2020-05-08T08:28:32.0332478Z     - MD5Sum:86381d6cb11f9a6f657c38bd210c73c0 [weak]
2020-05-08T08:28:32.0332578Z    Hashes of received file:
2020-05-08T08:28:32.0332867Z     - SHA256:445b58aadd489c62ec98d38d96f51fc36b14940255606ce04d22e12ed3bfa2f5
2020-05-08T08:28:32.0333133Z     - SHA1:1084ff0ec91953d051609f55045f1775b88fe496 [weak]
2020-05-08T08:28:32.0333389Z     - MD5Sum:5d09fb2af74be1a9c701e9234cf81627 [weak]
2020-05-08T08:28:32.0333619Z     - Filesize:84324 [weak]
2020-05-08T08:28:32.0333974Z    Last modification reported: Fri, 08 May 2020 06:55:00 +0000
2020-05-08T08:28:32.0334155Z    Release file created at: Fri, 08 May 2020 07:55:23 +0000
2020-05-08T08:28:32.0334961Z E: Failed to fetch http://us-east1.gce.archive.ubuntu.com/ubuntu/dists/focal-updates/universe/binary-amd64/Packages.xz  
2020-05-08T08:28:32.0335215Z E: Some index files failed to download. They have been ignored, or old ones used instead.

I've restarted the failed job

@mvo5 mvo5 merged commit 0b662b3 into snapcore:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stolowski stolowski stolowski approved these changes

@zyga zyga zyga approved these changes

@anonymouse64 anonymouse64 anonymouse64 approved these changes

Assignees
No one assigned
Labels
Simple 😃 A small PR which can be reviewed quickly Skip spread Indicate that spread job should not run
Projects
None yet
Milestone
2.45
5 participants
@bboozzoo @anonymouse64 @stolowski @zyga @mvo5