Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: setup portals before starting user session #8708

Merged
merged 1 commit into from
May 25, 2020
Merged

tests: setup portals before starting user session #8708

merged 1 commit into from
May 25, 2020

Conversation

zyga
Copy link
Collaborator

@zyga zyga commented May 21, 2020

The portals contain session level services. We need to prepare them
ahead of starting the session or we risk running the real
implementation.

Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com

@zyga
tests: setup portals before starting user session
310b36c 
The portals contain session level services. We need to prepare them
*ahead* of starting the session or we risk running the real
implementation.

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
stolowski
stolowski approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@stolowski stolowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

sergiocazzolato
sergiocazzolato approved these changes May 22, 2020
View reviewed changes
Copy link
Collaborator

@sergiocazzolato sergiocazzolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the fix

jhenstridge
jhenstridge approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@jhenstridge jhenstridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good like a good change. As a bus activated service, it is unlikely that the wrong portal backend is actually used in the test. This should make the tests more robust against future changes though, or if they are used as a basis for other new tests.

@mvo5 mvo5 merged commit 2edb707 into snapcore:master May 25, 2020
@zyga zyga deleted the tweak/setup-portals-later branch May 25, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stolowski stolowski stolowski approved these changes

@sergiocazzolato sergiocazzolato sergiocazzolato approved these changes

@jhenstridge jhenstridge jhenstridge approved these changes

Assignees
No one assigned
Labels
Test Robustness
Projects
None yet
Milestone
No milestone
5 participants
@zyga @stolowski @sergiocazzolato @jhenstridge @mvo5