test: session-tool cli tweaks #8717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to support the -h switch in all the test helpers. This is one. Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
By moving the root check later we can run session-tool -h from a git checkout and see it operate. Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
Originally session-tool started with dash-dash options for triggering certain behavior, most prominently --prepare and --restore. This patch adds equivalent non-dash options for everything, in addition to the brand new "exec" command that replaces the undecorated "session-tool foo" invocation, to run "foo" inside a session. Note that almost no test changes are peformed, as this ought to be entirely backwards compatible. Subsequent patches will move the existing test catalogue over and at some point we will sunset the old names. The only exception is the test for session-tool, which nows shows the new syntax in use. Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains two main changes:
I didn't attempt to rename it to the new naming scheme yet as that is under discussion
and will be more invasive. This just sets the stage so that we can use
session-tool execeverywhere.
Please check each patch commit message for details. I specifically did not change the
bulk of the tests so that the new logic is shown to be backwards compatible.