snap/container.go: don't import snapdir, squashfs; use register format w/ init() #8727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t w/ init() Here we disentangle snap/container.go from importing snapdir and squashfs so that in a followup PR we can add an option struct to Install() that then is used in snapdir / squashfs implementations of Install(). We do this by having container.go export a register format function that is called during init() by the snapdir and squashfs packages. This required some refactoring to make snapdir work with a magic identifying function the way that squashfs currently does. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
|
this would require all real users of snap.Open to also import snap/squashfs and snap/snapdir on their own, this is a bit too annoying for this particular case. we need to find another path forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we disentangle snap/container.go from importing snapdir and squashfs so that in a followup PR we can add an option struct to Install() that then is used in snapdir / squashfs implementations of Install().
We do this by having container.go export a register format function that is called during init() by the snapdir and squashfs packages. This required some refactoring to make snapdir work with a magic identifying function the way that squashfs currently does.
This is needed by #8711 so that I can add an InstallOptions to Install() and use it to enforce that we don't ever create symlinks in some situations (like in run mode on uc20).