Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: backport preseed test fixes to 2.45 #8980

Closed

Conversation

stolowski
Copy link
Contributor

@stolowski stolowski commented Jul 6, 2020

These tests fail in 2.45 because of changes to ubuntu images (migration from core to core18+snapd snap in seeds); they were reflected and fixed in master some time ago. Draft because I'm checking if manual preseed tests are affected too.

@stolowski stolowski added this to the 2.45 milestone Jul 6, 2020
@stolowski
Copy link
Contributor Author

Spread test failures unrelated to this change - on debian-sid we will need to backport the fix for nfs changes (it fails on unknown nfs option, was fixed in master).

…sid as it is not supported anymore and prints the following error:

mount.nfs: an incorrect mount option was specified
(this is caused by proto=udp part of "mount -t nfs localhost:/home /home -o nfsvers=3,proto=udp").
@stolowski
Copy link
Contributor Author

Spread test failures unrelated to this change - on debian-sid we will need to backport the fix for nfs changes (it fails on unknown nfs option, was fixed in master).

I've cherry-picked commit 41d38c4 from master to fix nfs test on debian.

@mvo5
Copy link
Contributor

mvo5 commented Jul 17, 2020

Are those cherry picks from master commits? If not merging this back is not going to be easy, ideally we just cherry pick commits from master (and maybe fix small conflicts in there).

@anonymouse64 anonymouse64 self-requested a review July 21, 2020 13:36
@anonymouse64
Copy link
Member

The relevant fixes have now been handled by @bboozzoo with #9044, so I'm closing this for now to get the PR count down, happy to re-open if we do end up needing more of these backports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants