Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: work around bug in systemd/debian #9105

Merged
merged 1 commit into from Aug 7, 2020

Conversation

zyga
Copy link
Collaborator

@zyga zyga commented Aug 6, 2020

Work around systemd / Debian bug interaction. We are installing
libsystemd-dev which upgrades systemd to 246-2 (from 245-*) leaving
behind systemd-logind.service from the old version. This is tracked as
Debian bug https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=919509 and
it really affects Desktop systems where Wayland/X don't like logind from
ever being restarted. As a workaround, restart logind ourselves once
here. This change is generic, as it may happen on any distribution that
undergoes a similar transition.

Signed-off-by: Zygmunt Krynicki me@zygoon.pl

@zyga zyga added ⚠ Critical High-priority stuff (e.g. to fix master) Test Robustness labels Aug 6, 2020
Copy link
Member

@anonymouse64 anonymouse64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Collaborator

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Work around systemd / Debian bug interaction. We are installing
libsystemd-dev which upgrades systemd to 246-2 (from 245-*) leaving
behind systemd-logind.service from the old version. This is tracked as
Debian bug https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=919509 and
it really affects Desktop systems where Wayland/X don't like logind from
ever being restarted. As a workaround, restart logind ourselves once
here. This change is generic, as it may happen on any distribution that
undergoes a similar transition.

Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
@zyga zyga force-pushed the fix/work-around-systemd-debian-issue branch from 65a3f5b to b24b59f Compare August 7, 2020 06:25
@zyga
Copy link
Collaborator Author

zyga commented Aug 7, 2020

I pushed an || true to make it not fail on 14.04 where that service does not exist.

@zyga zyga merged commit f4dbd66 into snapcore:master Aug 7, 2020
@zyga zyga deleted the fix/work-around-systemd-debian-issue branch August 7, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠ Critical High-priority stuff (e.g. to fix master) Test Robustness
Projects
None yet
4 participants