gadget, osutil: use atomic file copy, adjust tests (2.45) #9108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regular CopyFile() call can only overwrite the destination location in place. Add a new helper that wraps the destination path with AtomicFile, to obtain a 2 stage write & commit (or cancel) behavior. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Use the CopyFileAtomic helper for moving file data around. Update the tests to match slightly changed semantics. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
this makes it a bit clearer that ATM some aspects of the behavior are closer to the AtomicWrite* family for consistency this involved also swapping argument order
anonymouse64
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #9103 for 2.45