Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix snap-routime-portal-info test #9315

Conversation

sergiocazzolato
Copy link
Collaborator

@sergiocazzolato sergiocazzolato commented Sep 10, 2020

It is failing because it can't find the binary to execute:

2020-09-10 09:45:27 Error executing
external:ubuntu-core-16-64:tests/main/snap-routine-portal-info
(external:ubuntu-core-16-64) :

tests.session -u test exec systemd-run --user --unit
test-snapd-desktop-sleep.service test-snapd-desktop.cmd sh -c 'touch
$SNAP_USER_DATA/1.stamp && exec sleep 1h'
Failed to find executable test-snapd-desktop.cmd: No such file or
directory

This test just fails on external backend

It is failing because it can't find the binary to execute:

2020-09-10 09:45:27 Error executing
external:ubuntu-core-16-64:tests/main/snap-routine-portal-info
(external:ubuntu-core-16-64) :
-----
+ tests.session -u test exec systemd-run --user --unit
test-snapd-desktop-sleep.service test-snapd-desktop.cmd sh -c 'touch
$SNAP_USER_DATA/1.stamp && exec sleep 1h'
Failed to find executable test-snapd-desktop.cmd: No such file or
directory

This test just fails on external backend
@sergiocazzolato sergiocazzolato added the Simple 😃 A small PR which can be reviewed quickly label Sep 10, 2020
@anonymouse64
Copy link
Member

like the other PR, I think we should look into why this test fails this way and what state are we not setting up when we prepare an external system such that /snap/bin is not on $PATH here

Copy link
Member

@anonymouse64 anonymouse64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the caveat that we add a TODO to investigate why this is necessary somewhere in tests.session

@sergiocazzolato sergiocazzolato merged commit 9a521b0 into snapcore:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
2 participants