Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boot: use test helpers #9416

Merged
merged 1 commit into from Sep 25, 2020
Merged

boot: use test helpers #9416

merged 1 commit into from Sep 25, 2020

Conversation

bboozzoo
Copy link
Collaborator

Make use of existing test state setup helpers.

@bboozzoo
boot: use test helpers
0fba069 
Make use of existing test state setup helpers.

Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
@bboozzoo bboozzoo added Simple 😃 A small PR which can be reviewed quickly UC20 Skip spread Indicate that spread job should not run labels Sep 25, 2020
zyga
zyga approved these changes Sep 25, 2020
View reviewed changes
Copy link
Collaborator

@zyga zyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a question

boot/assets_test.go Show resolved Hide resolved
mvo5
mvo5 approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvo5 mvo5 merged commit a31700f into snapcore:master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyga zyga zyga approved these changes

@mvo5 mvo5 mvo5 approved these changes

Assignees
No one assigned
Labels
Simple 😃 A small PR which can be reviewed quickly Skip spread Indicate that spread job should not run
Projects
None yet
Milestone
No milestone
3 participants
@bboozzoo @zyga @mvo5