Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boot/makebootable.go: set snapd_recovery_mode=install at image-build time #9654

Conversation

anonymouse64
Copy link
Member

This is the first step to doing away with the current default of
snapd_recovery_mode being unset implying "install". We need prepare-image (and
thus also ubuntu-image) to start writing "snapd_recovery_mode=install".

…time

This is the first step to doing away with the current default of
snapd_recovery_mode being unset implying "install". We need prepare-image (and
thus also ubuntu-image) to start writing "snapd_recovery_mode=install".

Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
@anonymouse64 anonymouse64 added Simple 😃 A small PR which can be reviewed quickly UC20 labels Nov 17, 2020
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@pedronis pedronis added this to the 2.48 milestone Nov 17, 2020
Copy link
Collaborator

@pedronis pedronis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@anonymouse64
Copy link
Member Author

I went through all the failures here and they are all related to the store returning 403's for the advise snap test and apt-hooks AFAICT.

@mvo5 mvo5 merged commit 7aea812 into snapcore:master Nov 17, 2020
@anonymouse64 anonymouse64 deleted the feature/uc20-make-bootable-20-set-snapd-recovery-mode branch November 17, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
3 participants