osutil/disks: allow building on mac os #9696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonymouse64
added
Simple 😃
This is to allow to continue compiling the snap command on darwin, as very soon the snap command imports bootloader, and the bootloader package will start importing the disks package. None of the functionality from the snap command however depends on actually using the disks package so it's sufficient to just provide stub implementations here. Note that to actually build the snap command on darwin, one must define the tags nomanagers and nosecboot with -tags nosecboot,nomanagers. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
anonymouse64
force-pushed
the
feature/disks-on-mac-os
branch
from
5b0518c
to
83c2223
Compare
bboozzoo
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow to continue compiling the snap command on darwin, as very soon
the snap command imports bootloader, and the bootloader package will start
importing the disks package. None of the functionality from the snap command
however depends on actually using the disks package so it's sufficient to just
provide stub implementations here.
Note that to actually build the snap command on darwin, one must define the tags
nomanagers and nosecboot with -tags nosecboot,nomanagers.
This will fix Mac "sanity" issues in #9695