Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sandbox/cgroup, tess/main: fix unit tests on v2 system, disable broken tests on sid #9828

Merged
merged 3 commits into from Jan 13, 2021

Conversation

bboozzoo
Copy link
Collaborator

Since 21.12.2020 (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=943981)
Debian Sid is using a unified cgroup hierarchy (v2). Disable tests that fail on
such system. Fix sandbox/cgroup unit tests to apply proper mocking of v1 support.

Otherwise the test breaks if run on a system with unified hierarchy (v2).

Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Since 21.12.2020 (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=943981)
Debian Sid is using a unified cgroup hierarchy (v2). Disable tests that fail on
such system.

Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
@bboozzoo bboozzoo added the Simple 😃 A small PR which can be reviewed quickly label Jan 12, 2021
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Copy link
Contributor

@stolowski stolowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@bboozzoo
Copy link
Collaborator Author

The failures on Ubuntu are in tests/main/snap-advise, and tests/main/apt-hooks, due to getting 429 Too Many Requests` when trying to download commands list from the store.

@mvo5 mvo5 merged commit b2def13 into snapcore:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
3 participants