interfaces/browser-support: allow sched_setaffinity with browser-sandbox: true #9865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…box: true This is used by chromium to try and optimize some render threads, and there are already more dangerous system calls allowed in the browser-sandbox: true policy. Additionally, on some user's machines this system call is called relentlessly by Chromium and thus ends up spamming the logs. Fixes: https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1900679 Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
anonymouse64
added
Simple 😃
bboozzoo
approved these changes
Jan 27, 2021
| # Chromium will attempt to set the affinity of it's renderer threads, primarily | ||
| # on android, but also on Linux where it is available. See | ||
| # https://github.com/chromium/chromium/blob/99314be8152e688bafbbf9a615536bdbb289ea87/content/common/android/cpu_affinity.cc#L51 | ||
| sched_setaffinity |
There was a problem hiding this comment.
Side observation, we already allow sched_setscheduler.
|
LGTM as well, there isn't much more security risk from this change given how privileged this interface already is. |
alexmurray
removed
the
Needs security review
pedronis
approved these changes
Jan 28, 2021
anonymouse64
deleted the
bugfix/browser-support-allow-set-sched-affinity
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used by chromium to try and optimize some render threads, and there are
already more dangerous system calls allowed in the browser-sandbox: true policy.
Additionally, on some user's machines this system call is called relentlessly by
Chromium and thus ends up spamming the logs.
Fixes: https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1900679