overlord/snapshotstate: include the last message printed by tar in the error #9953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e error When tar fails with a fatal error, include the last message it prints, as it will likely contain the actual error. Related to https://bugs.launchpad.net/stuttgart/+bug/1915781, where the root cause of the problem was caused by the directory getting modified while tar was processing it. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
mvo5
approved these changes
Feb 23, 2021
|
This looks fine but I wonder if we should include maybe the last ~5 messages or something (followup becuase this already improves things so we should take it :) |
anonymouse64
approved these changes
Feb 23, 2021
There was a problem hiding this comment.
LGTM, but I agree with @mvo5's suggestion more messages would be better I think
|
I've added a followup in #9957, which keeps some number of the last lines tar printed. Only after I added more tests it also turned out that the matcher keeps only some number of lines from the beginning, so the new PR also fixes that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tar fails with a fatal error, include the last message it prints, as it
will likely contain the actual error.
Related to https://bugs.launchpad.net/stuttgart/+bug/1915781, where the root
cause of the problem was caused by the directory getting modified while tar was
processing it.
Supersedes #9941