tests/unit/go: use tests.session wrapper for running tests as a user #9976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We occasionally see the tests invariant check incorrectly pick up a 'test' user session dbus: 2021-03-01T08:55:18.3295048Z tests.invariant: root-files-in-home ok 2021-03-01T08:55:18.3296599Z tests.invariant: crashed-snap-confine ok 2021-03-01T08:55:18.3298081Z tests.invariant: lxcfs-mounted ok 2021-03-01T08:55:18.3299546Z tests.invariant: more than one dbus-daemon running 2021-03-01T08:55:18.3301790Z pid:67160 user:test cmdline:/usr/bin/dbus-daemon --session --address=systemd: --nofork --nopidfile --systemd-activation --syslog-only 2021-03-01T08:55:18.3303861Z tests.invariant: stray-dbus-daemon not-ok 2021-03-01T08:55:18.3305558Z tests.invariant: leftover-defer-sh ok 2021-03-01T08:55:18.3306643Z tests.invariant: system is corrupted Use the tests.session wrapper for running things as the 'test' user so that we can ensure a proper session cleanup afterwards. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
On 18.04, the following error is observed in secboot tests using fde hooks: "cannot run fde-reveal-key: Failed to start transient service unit: Invalid Type setting: exec" This is confirmed by running the following command on 18.04 using the same parameters as the actual FDE reveal key command: google:ubuntu-18.04-64 $ systemd-run --user --wait --collect --service-type=exec /bin/true Failed to start transient service unit: Invalid Type setting: exec The --help output of systemd-run includes --service-type, but the manpage does not, suggesting this may be a bug in systemd or its packaging. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
|
The secboot unit tests failed on 18.04. Looks like systemd-run from 237 does not accept --service-type=exec in the command line and unit tests would fail with We have some logic to skip the tests, which likely works on 16.04, but the logic used a different systemd-run invocation from what the code does. I've pushed a commit to do the check correctly. It can even be confirmed in the VMs: |
anonymouse64
reviewed
Mar 3, 2021
tests/unit/go/task.yaml
Outdated
| @@ -25,13 +29,13 @@ execute: | | |||
| skip="${skip:-} SKIP_NAKEDRET=1" | |||
| fi | |||
|
|
|||
| su -l -c "cd /tmp/static-unit-tests/src/github.com/snapcore/snapd && \ | |||
| tests.session -u test exec sh -c "cd /tmp/static-unit-tests/src/github.com/snapcore/snapd && \ | |||
There was a problem hiding this comment.
I think we should have a switch here for trusty, to use su -l -c on trusty so that we can still get unit test coverage on trusty, but all the rest of the systems which support tests.session can benefit from not leaking the processes as you noticed
The tests.session helper requires busctl which is not available on 14.04, however we still want to run tests on those systems. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
…-misdetected-stray
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We occasionally see the tests invariant check incorrectly pick up a 'test' user
session dbus:
Use the tests.session wrapper for running things as the 'test' user so that we
can ensure a proper session cleanup afterwards.