snapstate: add "kernel-assets" to featureSet #9999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the "kernel-assets" string to the feature set of snapd. With that snaps can use: `assumes: [kernel-assets]` and snapd will ensure that the snaps that need this feature (like the new gadget and kernel) will only be installed when there is an updated version of snapd.
mvo5
added a commit
to mvo5/pi-gadget.xxx
that referenced
this pull request
Mar 9, 2021
Snapd is in the process of supporting DTBs coming from the kernel
snap. This requires an update of the gadget.yaml to point to the
kernel snap for boot assets of the form `$kernel:ref`.
The coresponding kernel snap change requires adding a file
meta/kernel.yaml with the content:
```
assets:
pidtbs:
update: true
content:
- dtbs/broadcom/
- dtbs/overlays/
```
This can only land for real once snapd is fully ready, the last
PR that needs to land is snapcore/snapd#9999
Note that this PR also tweaks the "classic" target as well but I did
not test this, because I don't know how it's called. For classic
the new syntax cannot be used because ubuntu-image needs help from
`snap prepare-image` to do the resolving of the content. But the
new `no-kernel-refs-gadget` in the makefile should ensure things
work like before for classic images.
mvo5
added a commit
to mvo5/pi-gadget.xxx
that referenced
this pull request
Mar 9, 2021
Snapd is in the process of supporting DTBs coming from the kernel
snap. This requires an update of the gadget.yaml to point to the
kernel snap for boot assets of the form `$kernel:ref`.
The coresponding kernel snap change requires adding a file
meta/kernel.yaml with the content:
```
assets:
pidtbs:
update: true
content:
- dtbs/broadcom/
- dtbs/overlays/
```
This can only land for real once snapd is fully ready, the last
PR that needs to land is snapcore/snapd#9999
Note that this PR also tweaks the "classic" target as well but I did
not test this, because I don't know how it's called. For classic
the new syntax cannot be used because ubuntu-image needs help from
`snap prepare-image` to do the resolving of the content. But the
new `no-kernel-refs-gadget` in the makefile should ensure things
work like before for classic images.
mvo5
added a commit
to mvo5/pi-gadget
that referenced
this pull request
Mar 9, 2021
Snapd is in the process of supporting DTBs coming from the kernel
snap. This requires an update of the gadget.yaml to point to the
kernel snap for boot assets of the form `$kernel:ref`.
The coresponding kernel snap change requires adding a file
meta/kernel.yaml with the content:
```
assets:
pidtbs:
update: true
content:
- dtbs/broadcom/
- dtbs/overlays/
```
This can only land for real once snapd is fully ready, the last
PR that needs to land is snapcore/snapd#9999
Note that this PR also tweaks the "classic" target as well but I did
not test this, because I don't know how it's called. For classic
the new syntax cannot be used because ubuntu-image needs help from
`snap prepare-image` to do the resolving of the content. But the
new `no-kernel-refs-gadget` in the makefile should ensure things
work like before for classic images.
|
This needs a final round of end-to-end testing with the real pi-kernel (channel 20/beta/kernel-assets) and real pi gadget (20/beta/kernel-asset, not the different spelling) and then it can be merged. |
sil2100
pushed a commit
to snapcore/pi-gadget
that referenced
this pull request
Apr 21, 2021
Snapd is in the process of supporting DTBs coming from the kernel
snap. This requires an update of the gadget.yaml to point to the
kernel snap for boot assets of the form `$kernel:ref`.
The coresponding kernel snap change requires adding a file
meta/kernel.yaml with the content:
```
assets:
pidtbs:
update: true
content:
- dtbs/broadcom/
- dtbs/overlays/
```
This can only land for real once snapd is fully ready, the last
PR that needs to land is snapcore/snapd#9999
Note that this PR also tweaks the "classic" target as well but I did
not test this, because I don't know how it's called. For classic
the new syntax cannot be used because ubuntu-image needs help from
`snap prepare-image` to do the resolving of the content. But the
new `no-kernel-refs-gadget` in the makefile should ensure things
work like before for classic images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the "kernel-assets" string to the feature set of snapd.
With that snaps can use:
assumes: [kernel-assets]and snapd willensure that the snaps that need this feature (like the new gadget
and kernel) will only be installed when there is an updated version
of snapd.
Build on top of PR #9981 - marked as blocked as we should only merge
it once we are confident in the new feature.