Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump base version of go to 1.13 #112

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Bump base version of go to 1.13 #112

merged 1 commit into from
Jun 14, 2021

Commits on Jan 13, 2021

  1. Bump base version of go to 1.13 

    There are two main reasons:

Go 1.10 fails to `go get` dependencies of spread as they have introduced build
flags unrecognized by 1.10, which causes spurious duplicate symbol errors. An
example can be seen on the test logs from
snapcore#111

    The command "eval go get -v -t ./... " failed.
    # golang.org/x/term
    ../../../golang.org/x/term/term_unix_linux.go:9:26: ioctlReadTermios redeclared in this block
	previous declaration at ../../../golang.org/x/term/term_unix_aix.go:9:26
    ../../../golang.org/x/term/term_unix_linux.go:10:27: ioctlWriteTermios redeclared in this block
	previous declaration at ../../../golang.org/x/term/term_unix_aix.go:10:2

This makes CI broken, this was not noticed simply because of low rate of
activity on the project.

The second reason is to get improved `go vet`, as certain issues have gone
unnoticed simply because the tooling was older.

I chose to bump the base version to Go 1.13 as it is used in Ubuntu 20.04 and
represents a reasonable upgrade.

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@huawei.com>
    Zygmunt Krynicki committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    bc6a287 View commit details
    Browse the repository at this point in the history