Bump base version of go to 1.13 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I see there are more places that pull in go 10.x, I'll adjust those later today. |
There are two main reasons: Go 1.10 fails to `go get` dependencies of spread as they have introduced build flags unrecognized by 1.10, which causes spurious duplicate symbol errors. An example can be seen on the test logs from snapcore#111 The command "eval go get -v -t ./... " failed. # golang.org/x/term ../../../golang.org/x/term/term_unix_linux.go:9:26: ioctlReadTermios redeclared in this block previous declaration at ../../../golang.org/x/term/term_unix_aix.go:9:26 ../../../golang.org/x/term/term_unix_linux.go:10:27: ioctlWriteTermios redeclared in this block previous declaration at ../../../golang.org/x/term/term_unix_aix.go:10:2 This makes CI broken, this was not noticed simply because of low rate of activity on the project. The second reason is to get improved `go vet`, as certain issues have gone unnoticed simply because the tooling was older. I chose to bump the base version to Go 1.13 as it is used in Ubuntu 20.04 and represents a reasonable upgrade. Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@huawei.com>
|
@niemeyer could you please merge this, it will help fix the CI loop. |
mvo5
approved these changes
Feb 24, 2021
|
@niemeyer please have a look, this will unlock other fixes that cannot pass CI currently. |
|
@zyga I will talk about this PR on Monday with Gustavo. I asked him to schedule time to look over the "ready" labeled PRs with me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two main reasons:
Go 1.10 fails to
go getdependencies of spread as they have introduced buildflags unrecognized by 1.10, which causes spurious duplicate symbol errors. An
example can be seen on the test logs from
#111
This makes CI broken, this was not noticed simply because of low rate of
activity on the project.
The second reason is to get improved
go vet, as certain issues have goneunnoticed simply because the tooling was older.
I chose to bump the base version to Go 1.13 as it is used in Ubuntu 20.04 and
represents a reasonable upgrade.
Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@huawei.com