Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the build #17

Merged
merged 2 commits into from Oct 8, 2023
Merged

fix the build #17

merged 2 commits into from Oct 8, 2023

Conversation

popey
Copy link
Contributor

@popey popey commented Oct 6, 2023

fixing the build of corsix-th. bumped to core22 and stripped down the libraries too.

snap/snapcraft.yaml Outdated Show resolved Hide resolved

grade: stable
confinement: strict

apps:
corsixth:
command: desktop-launch $SNAP/bin/corsix-th $SNAP/share/corsix-th/CorsixTH.lua
extensions: [ gnome ]
command: bin/launch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not tested, but this should work, removing the need for snap/local/bin/launch

Suggested change
command: bin/launch
command: usr/local/bin/corsix-th --interpreter=$SNAP/usr/local/share/corsix-th/CorsixTH.lua

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that and snapcraft complained about erroneous characters in the command line, so I moved it out to a launch script.

Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@sergiusens
Copy link
Contributor

sergiusens commented Oct 7, 2023 via email

@popey
Copy link
Contributor Author

popey commented Oct 7, 2023

Nope. tried that. If you don't specify the = it fails.

$ snap run corsixth
CorsixTH cannot find CorsixTH.lua. If you want use a custom location, specify it by --interpreter=FILE

Copy link
Member

@merlijn-sebrechts merlijn-sebrechts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I propose merging this to get it working again, and taking a stab at the cosmetic issue later

@merlijn-sebrechts merlijn-sebrechts merged commit 8ea4201 into snapcrafters:master Oct 8, 2023
@popey
Copy link
Contributor Author

popey commented Oct 8, 2023

It's failing to build now, looking for libmfx1...

https://launchpadlibrarian.net/690973096/buildlog_snap_ubuntu_jammy_arm64_69683c0c6722af9883200c5ffd5f2fa7_BUILDING.txt.gz

but it built fine locally...

Initializing parts lifecycle
Executing parts lifecycle...
Executing parts lifecycle: pull corsixth
Executing action
Stage package not found in part 'corsixth': libmfx1.
Full execution log: '/root/.local/state/snapcraft/log/snapcraft-20231008-184145.543169.log'
Build failed

@lewri lewri mentioned this pull request Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants