New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the build #17
fix the build #17
Conversation
|
||
grade: stable | ||
confinement: strict | ||
|
||
apps: | ||
corsixth: | ||
command: desktop-launch $SNAP/bin/corsix-th $SNAP/share/corsix-th/CorsixTH.lua | ||
extensions: [ gnome ] | ||
command: bin/launch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have not tested, but this should work, removing the need for snap/local/bin/launch
command: bin/launch | |
command: usr/local/bin/corsix-th --interpreter=$SNAP/usr/local/share/corsix-th/CorsixTH.lua |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried that and snapcraft complained about erroneous characters in the command line, so I moved it out to a launch script.
Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Ah, the = sign in the command, which can probably be removed too
Em sáb., 7 de out. de 2023 11:50, Alan Pope ***@***.***>
escreveu:
… ***@***.**** commented on this pull request.
------------------------------
In snap/snapcraft.yaml
<#17 (comment)>:
>
grade: stable
confinement: strict
apps:
corsixth:
- command: desktop-launch $SNAP/bin/corsix-th $SNAP/share/corsix-th/CorsixTH.lua
+ extensions: [ gnome ]
+ command: bin/launch
I tried that and snapcraft complained about erroneous characters in the
command line, so I moved it out to a launch script.
—
Reply to this email directly, view it on GitHub
<#17 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIX7ZIKAOSJIT3RYYWCMO3X6FT3VAVCNFSM6AAAAAA5WOWLBKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNRTGA3DGNZXGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Nope. tried that. If you don't specify the = it fails.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I propose merging this to get it working again, and taking a stab at the cosmetic issue later
It's failing to build now, looking for libmfx1... but it built fine locally...
|
fixing the build of corsix-th. bumped to core22 and stripped down the libraries too.