Snap not building - fixed issue #37
Conversation
Fix build issues
|
stand by - I see my error... |
|
That's more like it! |
Implementing test builds on `testing` branch. Makes far more sense.
|
Let me know if there's anything else needed. It's passing builds from my end and I have the locally built snap running in my home network. |
Just in case there were any more errors from snapcraft.io.
last commit no good.
Included naming conventions, as build seemed to work in commit: kz6fittycent@a2e4c60
apparently the new naming convention isn't working. Reverted to older one from core20.
|
Not sure why, but the test builds are passing in my repo. I just merged a core22 based version into my master branch, and it's passing. AFAICT, we have the same GH actions. EDIT: I just confirmed that they (the workflow yml's) are, in fact, the same. So I am puzzled why the test builds are failing in this repo, versus mine. That said, I am currently running the latest version of Jenkins, built locally. EDIT AGAIN: OK, I am not so happy with these test builds! They seem to be hit or miss, leading me to believe that we were good to go. I've added a cleanup section to the bottom of the yaml, and that seems to be working in BOTH my branches (master and testing). |
Added cleanup section - used in mc-installer. I'm at a loss after this. The failed tests seem to be hit/miss and that makes no sense to me. Whatever, here we go!
I'm reverting back to core20 since the testing branch is working as expected, and no failures. If this doesn't work, I am done and closing the PR.
license: MIT
|
@merlijn-sebrechts - if you (or another party) don't mind taking another look at this PR, I think it's ready. I say that with some reservation given the experiences I've had with the ~50/50 build failure/success rate. The latest commit is working and I've even upgraded to |
There was a problem hiding this comment.
LGTM!
I'm assuming the weird issues were because we're running snapcraft review-tools after the build, and you might not be doing that. Snapcraft review-tools is what the store runs before publishing your snap, so all snaps must pass this automated review.
Per our discussion on https://forum.snapcraft.io/t/jenkins-snaps-not-building/37368/3