Logic for upstream version sync added #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the default, but I am concerned that the release tags will still cause an issue with the workflows triggering another build against the LTS.
Used some bash to make sure that the upstream version is always newer than the last version in the snapcraft.yaml, since the LTS version is always behind.
matches `stable` release for the snap
jnsgruk
reviewed
Dec 15, 2023
jnsgruk
reviewed
Dec 15, 2023
Thanks Jon!
jnsgruk
reviewed
Dec 15, 2023
jnsgruk
reviewed
Dec 15, 2023
Co-authored-by: Jon Seager <jon@sgrs.uk>
Co-authored-by: Jon Seager <jon@sgrs.uk>
|
@jnsgruk I'll take a look at using |
jnsgruk
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way Jenkins releases their LTS vs Latest, it caused an issue with the latest snap build and release to candidate, where the version built, albeit Jenkins' latest LTS, was not the same branch we've been building against. I am hopeful that this change will prevent it in the future. Otherwise, we can just set a hard number in the file (snap a line on a specific version) and anything greater than that would be built, and lower version numbers wouldn't - I hope.
This is working in local testing but I do not have the same actions set up for my repos, yet, so I have to rely on this to perform the test.