LTS Track for Jenkins Snap #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing local build
jnsgruk
reviewed
May 23, 2024
changed to `snapcrafters/ci/release-to-candidate@main`
jnsgruk
reviewed
Jun 1, 2024
Comment on lines
14
to
27
| jobs: | ||
| sync: | ||
| name: 🔄 Sync version with upstream | ||
| environment: "Candidate Branch" | ||
| environment: "LTS Branch" | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: 🔄 Sync version with upstream | ||
| uses: snapcrafters/ci/sync-version@main | ||
| with: | ||
| token: ${{ secrets.SNAPCRAFTERS_BOT_COMMIT }} | ||
| update-script: | | ||
| # Grabbing latest release | ||
| VERSION=$(curl -sL https://api.github.com/repos/jenkinsci/jenkins/releases | jq .[].tag_name -r | grep -v rc | sort -r | head -n 1 | cut -d "-" -f2) | ||
| # Grabbing latest lts release | ||
| VERSION=$(curl -sL https://api.github.com/repos/jenkinsci/jenkins/releases | jq .[].tag_name -r | grep -v rc | sort -r | grep "2.440" | head -n1 | cut -d "-" -f2) | ||
| sed -i 's/^\(version: \).*$/\1'"'$VERSION'"'/' snap/snapcraft.yaml |
There was a problem hiding this comment.
This file can be removed, and you'll need to add another stanza to the update script on the candidate branch, because scheduled workflows only run on the default branch. See sublime-text or sublime-merge for an example :)
jnsgruk
reviewed
Jun 1, 2024
Comment on lines
11
to
17
| jobs: | ||
| promote: | ||
| name: ⬆️ Promote to stable | ||
| environment: "Candidate Branch" | ||
| environment: "LTS Branch" | ||
| runs-on: ubuntu-latest | ||
| if: | | ||
| ( !github.event.issue.pull_request ) |
There was a problem hiding this comment.
This file can also be removed, you'll need to delete this on this branch, then update the promotion workflow on candidate
jnsgruk
reviewed
Jun 1, 2024
| @@ -46,7 +46,7 @@ jobs: | |||
| call-for-testing: | |||
| name: 📣 Create call for testing | |||
| needs: [release, get-architectures] | |||
| environment: "Candidate Branch" | |||
| environment: "LTS Branch" | |||
| runs-on: ubuntu-latest | |||
There was a problem hiding this comment.
Needs a channel argument in most of the steps, per: https://github.com/snapcrafters/sublime-merge/blob/3e350971a6a3394a10546d39963076b3ad9c3598/.github/workflows/release-to-candidate.yml#L46
|
A few more comments now I understand better - thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #81