Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classic confinement #1

Merged
merged 2 commits into from Mar 14, 2019
Merged

Classic confinement #1

merged 2 commits into from Mar 14, 2019

Conversation

brlin-tw
Copy link
Contributor

@brlin-tw brlin-tw commented Dec 9, 2018

This PR fixes an issue in classic confinement compatibility and flips the snap to classic confinement.

The 70cd3de commit, while making classic confinement work, breaks the snap in strict confinement and make an assumption that the core snap is installed.

This patch stages the ncurses-base and uses the in-snap terminfo files to fix the issue.

Signed-off-by: 林博仁(Buo-ren, Lin) Buo.Ren.Lin@gmail.com

Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>
@brlin-tw brlin-tw changed the title Fix classic confinement compatibility(take 2) Classic confinement Dec 9, 2018
@brlin-tw
Copy link
Contributor Author

@Ads20000 @diddledan @ElOpio @evandandrea @flexiondotorg @javacruft @om26er @popey
Can anyone please review this?

@popey popey merged commit ba65e0b into snapcrafters:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants