Fix "Error opening terminal: xterm-256color." error when launching #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The snap lacks files from the ncurses-base package, which was not shipped in the snap nor the ncurses-launch stage snap, causing the error. This patch also migrates to the new implementation of ncurses-launch launcher, which dumps the source repository instead of using the built stage-snap, which is no longer unsupported. Fixes snapcrafters#23. Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
|
The CI failure doesn't seem to be related to the PR...: @diddledan Any thoughts? |
|
I suspect the GitHub Actions script is broken - I've created a new PR #29 to hopefully fix it |
ghost
approved these changes
Jun 1, 2021
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The snap lacks files from the ncurses-base package, which was not
shipped in the snap nor the ncurses-launch stage snap, causing the
error.
This patch also migrates to the new implementation of ncurses-launch
launcher, which dumps the source repository instead of using the built
stage-snap, which is no longer unsupported.
Fixes #23.
Signed-off-by: 林博仁(Buo-ren Lin) Buo.Ren.Lin@gmail.com