Point to correct ffmpeg location by default #13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned on the forum, OpenToonz can't find ffmpeg in the snap. The code expects
So the only good option in order to have ffmpeg work by default in this snap is to configure the path of ffmpeg in the preferences.
This PR does that in two ways:
preferences.ini
which will be used to populate user preferences when the application first starts up. This, however, will not fix the issue for existing installations of this Snap.ensure-defaults.sh
scripts to insert/modify the ffmpeg path in existing user preferences. This, however, will not fix the issue for new installations of this Snap.Both of these combined fix the issue for both new and existing installations of this snap.
To test this, install the snap, run it, close the "opentoonz startup" dialog and choose the menu item
Render
>Fast Render to MP4
. You should see a box "the command cannot be executed because the scene is empty" instead of "ffmpeg not found".