Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: add password-manager-service to the plugs #15

Closed
V-Gira opened this issue Apr 14, 2024 · 3 comments
Closed

[Enhancement]: add password-manager-service to the plugs #15

V-Gira opened this issue Apr 14, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@V-Gira
Copy link
Contributor

V-Gira commented Apr 14, 2024

What changes would you like?

There is a password-manager-service interface that could allow the Wire Snap to access the desktop environment's keychain

Any extra information?

Hi @popey , and happy belated birthday!

I work at Wire, and our latest release introduced an issue for some of our Linux users, most relevant the Snap has become unusable.

We started to use the system keychain to store users' authentication data, relying on Electron's safeStorage, and AppArmor policies now prevent users using the Snap package to log in.

I am not familiar with Snaps, a bit of digging makes me believe we would need to add the password-manager-service interface to the list of plugs in the .yaml file.

I would be very grateful if you could help me solve this issue, just pointing me in the right direction would be appreciated, I'm perfectly fine submitting a PR.

Thank you for all you're doing,, Linux support for Wire is not yet in the card unfortunately, but I'll be happy to help in anyway I can to render the Snap usable again.

Don't hesitate to reach out, thanks again!

@V-Gira V-Gira added the enhancement New feature or request label Apr 14, 2024
@V-Gira
Copy link
Contributor Author

V-Gira commented Apr 17, 2024

Unfortunately, I have not been able to build a working Snap following those steps on an Ubuntu VM:

snap download wire
unsquashfs wire_365.snap
  • edit the snap.yaml file in ./squashfs-root/meta to add password-manager-service to the plugs
snap pack squashfs-root
snap install ./wire_3.32.3079_amd64.snap --dangerous

The resulting Snap starts properly at that point but suffers from the issue as password-manager-service is not connected

after connecting the interface:

snap connect wire:password-manager-service

The Snap hangs on start up following those steps. I seem to be missing something.

@V-Gira
Copy link
Contributor Author

V-Gira commented Apr 18, 2024

I was apparently mistaken, the above steps worked perfectly on an up to date system (ubuntu and kubuntu). I'll raise a PR

@jnsgruk
Copy link
Member

jnsgruk commented Jun 11, 2024

Fixed in #16

@jnsgruk jnsgruk closed this as completed Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants