-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for new statement properties #870
feat: add support for new statement properties #870
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files📢 Thoughts on this report? Let us know! |
Whats the SQL command to change prod DB? |
Don't have any yet, I used a GUI |
wdyt about ALTER TABLE statements
MODIFY id VARCHAR(66) NOT NULL,
MODIFY delegate VARCHAR(100) NOT NULL,
MODIFY space VARCHAR(100) NOT NULL,
ADD COLUMN network VARCHAR(24) NOT NULL DEFAULT 's',
ADD COLUMN discourse VARCHAR(64),
ADD COLUMN status VARCHAR(24) NOT NULL DEFAULT 'inactive',
DROP PRIMARY KEY,
ADD PRIMARY KEY (delegate, space, network),
ADD INDEX space (space),
ADD INDEX network (network),
ADD INDEX status (status); |
why default to |
Decided by Fabien |
Seems good. Maybe also proceed to the COLLATON change, since this table is small, and not related to anything else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utAck
Related to snapshot-labs/sx-monorepo#407
Return new statement properties