-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Space user profile page #407
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like typecheck is failing
|
||
export const updateStatementTypes = { | ||
Statement: [ | ||
{ name: 'from', type: 'address' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from
is now string
right? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not until the starknet PR is merged
|
||
const navigation = computed(() => [ | ||
{ label: 'Statement', route: 'space-user-statement' }, | ||
{ label: 'Delegators', route: 'space-user-delegators' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's about missing "count" next to Delegators (on UI we have counter that shows 6, but here we don't show any counter).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops yes, sorry for the typos
@wa0x6e removed |
Co-authored-by: Chaitanya <yourchaitu@gmail.com>
…hot-labs/sx-monorepo into fix-388-user-space-profile
Summary
This PR add a new user profile page, under each space, summarizing the user activities for the given space
In order to facilitate reviewing, this feature will be split into multiple PR, and this one will only handle the skeleton and routes to all pages, as well as the everything related to the
STATEMENT
tab. All other pages (delegators, proposals and votes) will be empty, and populating them will come in a future PR.How to test
TODO
status
,discourse
) to SDK - feat: support additional statement properties snapshot.js#1023status
,discourse
) to Sequencer - feat: support new statement properties snapshot-sequencer#386status
,discourse
) to Hub - feat: add support for new statement properties snapshot-hub#870