Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Space user profile page #407

Open
wants to merge 105 commits into
base: master
Choose a base branch
from
Open

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Jun 17, 2024

Summary

This PR add a new user profile page, under each space, summarizing the user activities for the given space

In order to facilitate reviewing, this feature will be split into multiple PR, and this one will only handle the skeleton and routes to all pages, as well as the everything related to the STATEMENT tab. All other pages (delegators, proposals and votes) will be empty, and populating them will come in a future PR.

How to test

  1. Go to a space leaderboard
  2. Click on an user
  3. It should redirect you to the space user profile page
  4. For onchain spaces, it should show the correct number of proposals and votes
  5. It should display the user's voting power on this space
  6. It should show the user's statement if available
  7. When it's your own profile, you should be able to edit it

TODO

Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like typecheck is failing

apps/ui/src/views/SpaceUser.vue Outdated Show resolved Hide resolved

export const updateStatementTypes = {
Statement: [
{ name: 'from', type: 'address' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from is now string right? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not until the starknet PR is merged

packages/sx.js/src/clients/offchain/ethereum-sig/index.ts Outdated Show resolved Hide resolved

const navigation = computed(() => [
{ label: 'Statement', route: 'space-user-statement' },
{ label: 'Delegators', route: 'space-user-delegators' },
Copy link
Member

@ChaituVR ChaituVR Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On design, we show count on delegators tab also

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's about missing "count" next to Delegators (on UI we have counter that shows 6, but here we don't show any counter).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops yes, sorry for the typos

apps/ui/src/views/SpaceUser/Votes.vue Show resolved Hide resolved
@Sekhmet
Copy link
Member

Sekhmet commented Jul 16, 2024

@wa0x6e removed Closes: message as this PR is part of PR chain, after we merge this one it will still miss non-statement tabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants