Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[karma-discord-roles] feature: add karma-discord-roles #1210

Merged
merged 9 commits into from
Jul 18, 2023

Conversation

Arthh
Copy link
Contributor

@Arthh Arthh commented Jul 6, 2023

karma-discord-roles

- Karma Discord role strategy can be used by DAOs to provide voting power to contributors with a specific role on Discord.

@Arthh Arthh changed the title Feature/karma discord roles [strategy] feature: add karma-discord-roles Jul 6, 2023
@ChaituVR ChaituVR changed the title [strategy] feature: add karma-discord-roles [karma-discord-roles] feature: add karma-discord-roles Jul 9, 2023
@Arthh Arthh requested a review from ChaituVR July 16, 2023 20:33
@ChaituVR
Copy link
Member

Hi @Arthh We are good to merge if we can change the author. it should be your/your org github

Arthh and others added 2 commits July 18, 2023 05:43
Co-authored-by: Chaitanya <yourchaitu@gmail.com>
Co-authored-by: Chaitanya <yourchaitu@gmail.com>
@Arthh Arthh requested a review from ChaituVR July 18, 2023 09:44
@ChaituVR ChaituVR merged commit 7d23684 into snapshot-labs:master Jul 18, 2023
5 checks passed
@zzuziak
Copy link
Contributor

zzuziak commented Jul 23, 2023

Hi team 👋 I might be wrong, but I can see @Arthh, you never use snapshot for the strategy. Is it giving someone voting power even if they have just acquired the role on Discord? One of our requirements is to calculate the VP based on the snapshot of proposal. cc @ChaituVR

@ChaituVR
Copy link
Member

Correct, Informed them here https://discord.com/channels/707079246388133940/1126157732534288507/1130948591993761922 but discussing other changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants