Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tokio-tungstenite is incompatible with new tokio crate #33

Closed
Relrin opened this issue Feb 12, 2018 · 3 comments
Closed

tokio-tungstenite is incompatible with new tokio crate #33

Relrin opened this issue Feb 12, 2018 · 3 comments

Comments

@Relrin
Copy link

Relrin commented Feb 12, 2018

Hello,

Recently the tokio crate was reformed, and when you're trying to build an application or library with tokio crate (instead of tokio-core, and so on), it leads to breaking your actual codebase.

In my case with an application, when I had tried to update dependencies in the Cargo.toml file and re-build the project, I've got the following error:

error[E0308]: mismatched types
  --> src\proxy.rs:63:52
   |
63 |         let server = listener.incoming().for_each(|(stream, addr)| {
   |                                                    ^^^^^^^^^^^^^^ expected struct `tokio::net::TcpStream`, found tuple
   |
   = note: expected type `tokio::net::TcpStream`
              found type `(_, _)`

Does the tokio-tungstenite crate have any plans in migrating to the new tokio crate?

@daniel-abramov
Copy link
Member

Sure, I'll try to get back to it when I have a bit of time. At the first sight the migrating to the new tokio does not seem to impose big changes, most likely just minor changes in the signature of the functions. But I'll take a closer look at it a bit later anyway.

@bbigras
Copy link

bbigras commented May 4, 2018

Any progress on this?

@daniel-abramov
Copy link
Member

Yes, thanks to @Eroc33 . I'm closing this issue as #38 seems to solve the issue.

gregates pushed a commit to gregates/tokio-tungstenite that referenced this issue Feb 24, 2024
This is a security fix.
Fixes snapview#33.

Signed-off-by: Alexey Galakhov <agalakhov@snapview.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants