Skip to content

Commit

Permalink
fix unit test failure triggered by newer versions of mf2py or BS4 or ...
Browse files Browse the repository at this point in the history 
problem is that explicit p-name includes `<img>` `src` value, but implicit doesn't. background in microformats/microformats2-parsing#35 etc.

```
======================================================================
FAIL: test_activitypub_create_author_only_url (tests.test_webmention.WebmentionTest)
Mf2 author property is just a URL. We should run full authorship.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/ryan/src/bridgy-fed/local/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
  File "tests/test_webmention.py", line 383, in test_activitypub_create_author_only_url
    self.assert_equals(repost_as2, kwargs['json'])
  File "/Users/ryan/src/bridgy-fed/local/lib/python2.7/site-packages/oauth_dropins/webutil/testutil.py", line 182, in assert_equals
    %s""" % (msg, ''.join(e.args), expected, actual))
AssertionError: None: [actor] [name] u'Ms. \u2615 Baz' != u'Ms. \u2615 Baz  http://orig/pic'
- Ms. \u2615 Baz
+ Ms. \u2615 Baz  http://orig/pic

Expected value:
{u'@context': u'https://www.w3.org/ns/activitystreams',
 u'actor': {u'icon': ({u'type': u'Image', u'url': u'http://orig/pic'},),
            u'id': u'http://localhost/orig',
            u'image': ({u'type': u'Image', u'url': u'http://orig/pic'},),
            u'name': u'Ms. \u2615 Baz',
            u'preferredUsername': u'orig',
            u'type': u'Person',
            u'url': u'http://orig'},
 u'cc': [u'https://www.w3.org/ns/activitystreams#Public',
         u'http://orig/author',
         u'http://orig/recipient',
         u'http://orig/bystander'],
 u'id': u'http://a/repost',
 u'name': u'reposted!',
 u'object': u'tag:orig,2017:as2',
 u'type': u'Announce',
 u'url': u'http://a/repost'}
Actual value:
{u'@context': u'https://www.w3.org/ns/activitystreams',
 u'actor': {u'icon': [{u'type': u'Image', u'url': u'http://orig/pic'}],
            u'id': u'http://localhost/orig',
            u'image': [{u'type': u'Image', u'url': u'http://orig/pic'}],
            u'name': u'Ms. \u2615 Baz  http://orig/pic',
            u'preferredUsername': u'orig',
            u'type': u'Person',
            u'url': u'http://orig'},
 u'cc': [u'https://www.w3.org/ns/activitystreams#Public',
         u'http://orig/author',
         u'http://orig/recipient',
         u'http://orig/bystander'],
 u'id': u'http://a/repost',
 u'name': u'reposted!',
 u'object': u'tag:orig,2017:as2',
 u'type': u'Announce',
 u'url': u'http://a/repost'}
```
  • Loading branch information
@snarfed
snarfed committed Oct 11, 2018
1 parent b8d52b3 commit 6681a5f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/test_webmention.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ def test_activitypub_create_author_only_url(self, mock_get, mock_post):
author = requests_response("""\
<html>
<body class="h-card">
<a class="p-name u-url" rel="me" href="http://orig">Ms. ☕ Baz</span>
<a class="p-name u-url" rel="me" href="http://orig">Ms. ☕ Baz</a>
<img class="u-photo" src="/pic" />
</body>
</html>
Expand Down

0 comments on commit 6681a5f

Please sign in to comment.