Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the acct: URI for this domain, if in h-card #27

Merged
merged 1 commit into from
Apr 16, 2018

Conversation

singpolyma
Copy link
Contributor

This allows users to choose their own username for their webfinger ID.

Closes #3

Copy link
Owner

@snarfed snarfed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was skeptical, but this seems about as safe as possible. thanks for the comprehensive test too. with a bit more logging, i'll happily merge!

if url.startswith('acct:'):
urluser, urldomain = util.parse_acct_uri(url)
if urldomain == domain:
acct = '%s@%s' % (urluser, domain)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind logging here that we're use this overridden acct: url?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

This allows users to choose their own username for their webfinger ID.

Closes snarfed#3
@snarfed
Copy link
Owner

snarfed commented Apr 16, 2018

thanks again for the contribution!

@snarfed snarfed merged commit 5257099 into snarfed:master Apr 16, 2018
@snarfed
Copy link
Owner

snarfed commented Apr 16, 2018

deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants