Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

likes have "Bridgy Response" instead of users' names #516

Closed
drikkes opened this issue Oct 20, 2015 · 29 comments
Closed

likes have "Bridgy Response" instead of users' names #516

drikkes opened this issue Oct 20, 2015 · 29 comments
Labels

Comments

@drikkes
Copy link

drikkes commented Oct 20, 2015

There's a change in how Bridgy pulls FB data. Before it looked all fine like this for example: http://drikkes.com/?p=9850#comments (You have to change to the "Reaktionen" tab below the blogpost - or take a look at the screenshot.

screenshot 2015-10-20 13 44 56

Compared to this newer post: http://drikkes.com/?p=10062 you see what's different. Since some time FB users and the source don't appear with the "real" names, but with the app's one.

screenshot 2015-10-20 13 48 42

Anyone else has a problem like this?

@singpolyma
Copy link
Contributor

Do you have the semantic linkbacks plugin installed?

@drikkes
Copy link
Author

drikkes commented Oct 20, 2015

Yes from the Indieweb plugins I've installed Semantic Linkbacks and WebMentions. But in my newest post from today it seems to okay again. In the meantime I deleted some other plugins, like the official FB one. MAybe it was an interference.
(I changed my theme to an updated version, this caused diverse troubles. So I changed it back and cleaned the backend a bit.)

@drikkes
Copy link
Author

drikkes commented Oct 20, 2015

Unfortunately, that is not correct. Now I have both in today's published http://drikkes.com/?p=10082#comments. Seems to work with FB comments, and fails with likes...

screenshot 2015-10-20 17 52 19

@snarfed
Copy link
Owner

snarfed commented Oct 20, 2015

thanks for the report and triage, and sorry for the trouble! i actually saw this recently too: #498 (comment) . i dug in a bit and didn't quite figure it out, but i think i have a lead now, and it definitely helps to know that it's just likes, not comments.

i'll look more soon.

@snarfed snarfed changed the title Facebook is now Bridgy Appspot facebook likes have "Bridgy Response" instead of users' names Oct 20, 2015
@snarfed
Copy link
Owner

snarfed commented Oct 21, 2015

huh: this isn't happening to other servers, e.g. Known: http://werd.io/2015/i-love-marty-mcfly-too-but-more-importantly-the-first#comments

more interestingly, even other WordPress servers are still getting names ok for Facebook likes: http://papapelz.de/994#comment

@armingrewe
Copy link

As far as I can see it's fine for me as well, they show up with the names as they should (on http://www.islay.org.uk/)

@drikkes
Copy link
Author

drikkes commented Oct 21, 2015

What can I do to repair it on my site? Delete and reinstall the Semantic Linkback plugin would be enough?

@snarfed
Copy link
Owner

snarfed commented Oct 21, 2015

@drikkes i don't know yet what's causing it, or how to fix it. :/

@armingrewe thanks for the data point!

@snarfed
Copy link
Owner

snarfed commented Oct 21, 2015

my current theory is that this only affects FB photo posts, since i've been messing with backfeed for those recently. (the two counterexamples i gave aren't photo posts.)

@snarfed
Copy link
Owner

snarfed commented Oct 21, 2015

another data point: i did get one good name along with all the bad ones on a recent post (https://snarfed.org/2015-10-02_15601). i think the difference is that she's the only user in that group who's ever authed bridgy.

screen shot 2015-10-21 at 2 01 04 pm

@snarfed
Copy link
Owner

snarfed commented Oct 21, 2015

here's the URL for that good like: https://www.brid.gy/like/facebook/212038/10101911886940043/100000224384191

and a bad one on the same post: https://www.brid.gy/like/facebook/212038/10101911886940043/10101611519838123

the html diff doesn't show any meaningful difference, from what i can tell:

24c24
<   <span class="u-uid">tag:facebook.com,2013:10101911886940043_liked_by_100000224384191</span>
---
>   <span class="u-uid">tag:facebook.com,2013:10101911886940043_liked_by_10101031520017413</span>
29,30c29,30
<     <div class="p-name"><a class="u-url" href="https://www.facebook.com/100000224384191">Gina Rossman Barrett</a></div>
<     <img class="u-photo" src="https://graph.facebook.com/v2.2/100000224384191/picture?type=large" alt="" />
---
>     <div class="p-name"><a class="u-url" href="https://www.facebook.com/10101031520017413">Sam Z. Glassenberg</a></div>
>     <img class="u-photo" src="https://graph.facebook.com/v2.2/10101031520017413/picture?type=large" alt="" />

...but now i suspect those URLs aren't the ones we actually used, since the name rendered on the post is Gina Barrett, but the name in the good link i posted above is Gina Rossman Barrett. hrmph.

@snarfed
Copy link
Owner

snarfed commented Oct 21, 2015

i've confirmed that those two URLs are indeed the original webmention source URLs. so, i have no idea what's going on. :/

@snarfed
Copy link
Owner

snarfed commented Oct 26, 2015

still happening. :( http://drikkes.com/?p=10114#wordpress-tab

@snarfed
Copy link
Owner

snarfed commented Oct 27, 2015

this just happened to me on an instagram like. (!) so i guess it's not facebook specific.

https://snarfed.org/2015-10-13_15826#comment-2592717
https://instagram.com/p/8yB-eMsqOS/

screen shot 2015-10-27 at 7 08 32 am

@snarfed snarfed changed the title facebook likes have "Bridgy Response" instead of users' names likes have "Bridgy Response" instead of users' names Oct 27, 2015
@snarfed
Copy link
Owner

snarfed commented Oct 27, 2015

the markup looks normal:

<span class="p-author h-card">
  <a class="p-name u-url" href="http://instagram.com/amitp487">Amit Patel</a>
  <a class="u-url" href="http://instagram.com/475182935"></a>
  <img class="u-photo" src="https://scontent.cdninstagram.com/hphotos-xaf1/t51.2885-19/11809647_905891949449784_5504662_a.jpg" alt="" />
</span>

<a class="u-url" href="https://instagram.com/p/8yB-eMsqOS/#liked-by-475182935">https://instagram.com/p/8yB-eMsqOS/#liked-by-475182935</a>
<div class="e-content p-name">
  <a class="u-like u-like-of" href="https://instagram.com/p/8yB-eMsqOS/">likes this.</a>
  <a class="u-like u-like-of" href="https://snarfed.org/2015-10-13_15826"></a>
</div>

@singpolyma
Copy link
Contributor

I it possible the pings went out twice and updates are failing?

@snarfed
Copy link
Owner

snarfed commented Oct 27, 2015

the source page is https://brid-gy.appspot.com/like/instagram/snarfed/1094946350483809170_420973239/475182935

when my site received the webmention, it fetched the source page twice, once at 07:04:55.380 and once at 07:04:56.306 (PST). as far as i can tell, the responses to those requests and the response to the my manual request a few minutes later were all identical. all 200s, all had the exact same log (below), and all returned a 1300 byte response. so i'm pretty confident they saw the same markup i posted above.

here's the full response body and the log:

Fetching instagram:snarfed like ('1094946350483809170_420973239', '475182935')
Fetching https://api.instagram.com/v1/media/1094946350483809170_420973239?access_token=4209..., kwargs {}
Fetching https://api.instagram.com/v1/media/1094946350483809170_420973239?access_token=4209..., kwargs {}
Original post discovery found original posts set([]), mentions set([])
starting posse post discovery with syndicated http://instagram.com/p/8yB-eMsqOS/
posse post discovery found relationship(s) http://instagram.com/p/8yB-eMsqOS/ -> [u'https://snarfed.org/2015-10-13_15826']

(side note: i love that github now allows attaching arbitrary files to issues, but they whitelist extensions? really? and .html isn't on the whitelist?!?)

@snarfed
Copy link
Owner

snarfed commented Oct 27, 2015

based on the info above, i have to suspect this is a problem with https://github.com/pfefferle/wordpress-semantic-linkbacks . cc @pfefferle @acegiak @dshanske.

in the meantime, i thought of a dumb hack on the bridgy side that should fix this: special case likes and put the user's name inside <title>. :P

@singpolyma
Copy link
Contributor

@snarfed
Copy link
Owner

snarfed commented Oct 27, 2015

@singpolyma interesting, thanks for the pointer. we've mostly seen this on new webmentions, not just updates to existing ones. would that bug also apply then?

given that my site fetched the source page twice in the example above, i'm thinking maybe yes, but not sure.

@singpolyma
Copy link
Contributor

@snarfed The two fetches were probably one for the webmention plugin and one for semantic-linkback... so maybe not related after all.

@snarfed
Copy link
Owner

snarfed commented Oct 27, 2015

woo, the hack worked! https://snarfed.org/2015-10-13_15826#comment-2592717

@snarfed
Copy link
Owner

snarfed commented Oct 27, 2015

ok, today's new forensics (#516 (comment)) are pretty convincing evidence that bridgy is returning the correct expected markup in these cases, and the workaround in ec44614 is now preventing the Bridgy Response symptom, so i'm guessing the remaining bug is probably in pfefferle/wordpress-semantic-linkbacks#39 or pfefferle/wordpress-webmention#57 or nearby. so, i'm tentatively closing this for now.

@snarfed snarfed closed this as completed Oct 27, 2015
@drikkes
Copy link
Author

drikkes commented Oct 27, 2015

So me as a coding idiot waits for the WP plugins to update?

@snarfed
Copy link
Owner

snarfed commented Oct 27, 2015

@drikkes it should actually already be fixed, due to the workaround i added. i can revert that workaround after the WP plugins are fixed, but you shouldn't notice any change then.

you should be able to to fix your existing Bridgy Response likes by retrying them from your bridgy user page. you can even page back to see older responses now, thanks to #524.

@drikkes
Copy link
Author

drikkes commented Nov 30, 2015

Spotted a new version of this. http://drikkes.com/?p=10240#wordpress-tab
bildschirmfoto 2015-11-30 um 16 50 32
This time the commentator's name is the content of of the FB reply.

@snarfed
Copy link
Owner

snarfed commented Nov 30, 2015

@drikkes ugh, yeah, 've seen that pattern many times before with the wordpress plugins. i think often it's because semantic-linkbacks isn't installed and enabled, but sometimes it is, and i don't know what the cause is then.

bridgy's mf2 for those two comments looks fine:

i looked at the bridgy logs from 3 hrs ago when your server fetched these comments, and they served fine, so i have to guess this is also a bug in the wordpress plugin(s). :/

@drikkes
Copy link
Author

drikkes commented Nov 30, 2015

Thanks for the answer.

@snarfed
Copy link
Owner

snarfed commented Mar 23, 2021

@dshanske @pfefferle just fyi I'm undoing the workaround for this "Bridgy Response" webmention display problem in WordPress. it's over 5y old, and we thought something in in pfefferle/wordpress-semantic-linkbacks#39 or pfefferle/wordpress-webmention#57 or nearby probably fixed it, so I doubt it will recur, but if it does, please come back here and let us know!

snarfed added a commit that referenced this issue Mar 25, 2021
specifically using "Bridgy Response" HTML title for liker's name.

for #516. not sure that this has been fixed in the wordpress plugins, but hope so, in pfefferle/wordpress-semantic-linkbacks#39 or pfefferle/wordpress-webmention#57 or nearby. it's been 5y. :P
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants