-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry buttons and paging for all responses #524
Comments
definitely! sounds like this is the same idea as #183? the easy answer is just to show the retry button for every response on your user page. the catch is that user pages only show the last 10 responses. to get to earlier ones, I'd have to implement paging, or something similar, and I'm bad at UX. :P btw, as a workaround in the meantime, you can always send the missing webmentions manually using https://www.brid.gy/about#source-urls . |
Yes, sounds really equal. Sorry, didn't noticed this. I like your "easy answer". And my suggestion is to add a "load more" button on the bottom of the list. Then just load 10 more responses. and more and more :) I tried your workaround. It works. After hard efforts. So, this topic is really a case. |
added paging, backward at least: 189a47a |
now clearing cached webmention endpoints on retry too: d6661a6 those three commits get us almost all the way there. we still don't refetch the post itself - i made that call due to complexity - but we do everything else. |
Love the changes, thanks a lot. |
thanks! and yeah, i wanted a Newer link too. it's not quite so easy, given the way i implemented the Older link with a human-readable timestamp in the query param, but i'll see what i can do. |
…524 i think the only part missing now is to actually fetch their site's h-feed during this OPD. i think i'm ok with that.
also update datastore composite indices on Response: drop an old obsolete one and modify the one that h-feed refetch uses to walk recent responses to resend.
before this, we only cached webmention endpoint discovery results when we successfully fetched the page. this is a bit aggressive, since it means we'll cache transient network failures, but with the lower expiration (2h instead of 1d), and now that the retry button flushes the cache (#524), i think it's ok. for #534
If you've done something wrong (e.g. forgot to add webmention target) it would be very brilliant to remove the previously fetched single responses so you can re-add them again via manual polling after you've edited your (e.g. facebook) post.
The text was updated successfully, but these errors were encountered: