Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meetup.com: Modify error message when RSVPing to non-Meetup event #191

Closed
jamietanna opened this issue Feb 20, 2020 · 2 comments · Fixed by #193
Closed

Meetup.com: Modify error message when RSVPing to non-Meetup event #191

jamietanna opened this issue Feb 20, 2020 · 2 comments · Fixed by #193

Comments

@jamietanna
Copy link
Collaborator

jamietanna commented Feb 20, 2020 •
edited

As per https://matrix.to/#/!goyPJLbDdnCsVhbPvo:matrix.org/$15821256645028zziDx:matrix.org

(btw, we can improve the "no in-reply-to found" error msg when the in-reply-to exists but isn't a meetup event - eg plug https://snarfed.org/rsvp.html into https://brid.gy/meetup/7199313 - but that's minor)
@jamietanna
Copy link
Collaborator Author

What did you mean re "plug" that in there?

@snarfed
Copy link
Owner

snarfed commented Feb 20, 2020

thanks for filing! i just meant try to publish it. sorry for any confusion. 😁

jamietanna added a commit to jamietanna/granary that referenced this issue Mar 24, 2020
@jamietanna
Fix: Return better error when RSVPing to non Meetup event
eedde88 
However, the difficulty here is that this error is also returned in
cases where the `in-reply-to` is not set, so we need this error message
to cover both cases.

Closes snarfed#191.
@jamietanna jamietanna mentioned this issue Mar 24, 2020
Merged
snarfed pushed a commit that referenced this issue Mar 25, 2020
@jamietanna @snarfed
Fix: Return better error when RSVPing to non Meetup event
97efd28 
However, the difficulty here is that this error is also returned in
cases where the `in-reply-to` is not set, so we need this error message
to cover both cases.

Closes #191.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Return better error when RSVPing to non Meetup event jamietanna/granary
2 participants
@snarfed @jamietanna