Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't convert newlines to <br> when input is HTML #80

Closed
gRegorLove opened this issue Mar 8, 2016 · 5 comments
Closed

Don't convert newlines to <br> when input is HTML #80

gRegorLove opened this issue Mar 8, 2016 · 5 comments
Labels

Comments

@gRegorLove
Copy link

Specifically when converting HTML to Atom, the feed ends up with extra <br> around the existing <p>.

@snarfed
Copy link
Owner

snarfed commented Mar 8, 2016

👍

@snarfed
Copy link
Owner

snarfed commented Mar 8, 2016

(PRs welcome too, of course!)

@snarfed snarfed added the now label Apr 3, 2016
@snarfed
Copy link
Owner

snarfed commented Apr 5, 2016

notes to myself:

@gRegorLove
Copy link
Author

do mf2 parsers propagate these into content => text vs html, respectively?

e-content parses into value and html keys, but p-content wouldn't—just the plaintext value. It seems it would be safe to convert newlines in all instances except when the key is content => html

@snarfed
Copy link
Owner

snarfed commented Feb 7, 2018

belated: the actual fix commit was 795252e

snarfed added a commit that referenced this issue Feb 26, 2018
for #130, also re #80. i highly suspect this will cause a regression somewhere, but i'm not quite sure where yet. :/
snarfed added a commit that referenced this issue Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants