Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new tagged release #209

Closed
ruudk opened this issue Oct 26, 2015 · 15 comments
Closed

Create new tagged release #209

ruudk opened this issue Oct 26, 2015 · 15 comments

Comments

@ruudk
Copy link
Contributor

ruudk commented Oct 26, 2015

See #196 (comment)

Current master fixes a bug in PHP 7. Can you please create a new release?

@snc
Copy link
Owner

snc commented Oct 26, 2015

I'll try to find some time to tag a new release this week and have a look at all those other PRs and issues.

@csarrazi
Copy link

csarrazi commented Nov 4, 2015

Hello @snc! Any news on this?

@snc
Copy link
Owner

snc commented Nov 4, 2015

No, sorry, the problem is that the 1.1 and master branch are not in sync, so I can't simply add a new tag.

@mehmetbilgin
Copy link

+1 for a new release.
We need below fix for our production server.
#126

@vlceklukas
Copy link

+1

@snc
Copy link
Owner

snc commented Nov 21, 2015

I've now updated the master branch and could need some testers ;-)

@Ninir
Copy link

Ninir commented Jan 2, 2016

@snc Did you get sufficient feedbacks? What can we help you with?

@rdohms
Copy link

rdohms commented Jan 4, 2016

anything else stooping the release of a tag?

@snc
Copy link
Owner

snc commented Jan 5, 2016

Yes, I think it is a good idea to remove compatibility with older symfony versions to simplify the code and maintenance.

@ruudk
Copy link
Contributor Author

ruudk commented Jan 5, 2016

What about tagging current master as 1.1.20 and then start working on cleaning up ? Since current 1.1.19 does not work with PHP7 and some people are trying to upgrade. We are running master in production for a couple weeks now without problems.

@snc
Copy link
Owner

snc commented Jan 5, 2016

There are too many changes (1.1...master) for a patch version I think. I never checked if all of them are BC.

@cs278
Copy link

cs278 commented Jan 21, 2016

@snc What about cherry picking bf7bbf0 into 1.1 and release that?

@xocasdashdash
Copy link

any news about this? bf7bbf0 is pretty critical if you want to use redis to store Symfony sessions

@snc
Copy link
Owner

snc commented Jan 21, 2016

I've cherry-picked the commit and released it as 1.1.10.

@snc snc closed this as completed Jan 21, 2016
@cs278
Copy link

cs278 commented Jan 21, 2016

👍 Thanks @snc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants