Use single-argument ulimit calls #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some ulimit implementations (at least the one in dash, which is the /bin/sh implementation used by Debian derivatives) only accept setting one limit at a time. ```shell $ dash $ ulimit -t 20 -m 20 dash: 1: ulimit: too many arguments ``` This causes the limits set by benchpress to be ignored on these implementations when there are multiple (e.g. time and memory) limits. This patch changes the behavior to build a sequence of unrelated calls to `ulimit` (so `ulimit -t 20 ; ulimit -m 20 ; my_prover` instead of `ulimit -t 20 -m 20 ; my_prover`) for compatibility with these implementations.
|
Very nice, thank you. I probably ran into that at some point without realizing that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some ulimit implementations (at least the one in dash, which is the /bin/sh implementation used by Debian derivatives) only accept setting one limit at a time.
$ dash $ ulimit -t 20 -m 20 dash: 1: ulimit: too many argumentsThis causes the limits set by benchpress to be ignored on these implementations when there are multiple (e.g. time and memory) limits. This patch changes the behavior to build a sequence of unrelated calls to
ulimit(soulimit -t 20 ; ulimit -m 20 ; my_proverinstead ofulimit -t 20 -m 20 ; my_prover) for compatibility with these implementations.(I had seen the
ulimit: too many argumentserror messages many times in prover outputs without paying too much attention to it as it seemed to still work, but yesterday we had runaway prover instances that did not stop after 18+ hours which was definite proof it didn't work (: )