Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mzML export #267

Merged
merged 1 commit into from
Apr 25, 2022
Merged

fix: mzML export #267

merged 1 commit into from
Apr 25, 2022

Conversation

jorainer
Copy link
Collaborator

@jorainer
fix: mzML export
3b091f3 
- Don't export/write header variables with missing values (issue sneumann#266).
@jorainer
Copy link
Collaborator Author

This fixes issue #266 by correctly testing for missing values in C++. @sneumann not sure if this should be included/merged now or after the BioC 3.15 release.

@jorainer jorainer mentioned this pull request Apr 22, 2022
Closed
@sneumann
Copy link
Owner

Looks good and being a fix I'd say should go in now. Yours, Steffen

@sneumann sneumann merged commit 4745773 into sneumann:master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorainer @sneumann