Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConsumerKafkaBinding #268

Closed
jgonzalezlawyer opened this issue Aug 18, 2023 · 4 comments · Fixed by #276
Closed

ConsumerKafkaBinding #268

jgonzalezlawyer opened this issue Aug 18, 2023 · 4 comments · Fixed by #276
Assignees

Comments

@jgonzalezlawyer
Copy link

Hi,

the ConsumerKafkaBinding generates a class that not compile
https://github.com/sngular/scs-multiapi-plugin/blob/main/multiapi-engine/src/main/resources/templates/asyncapi/templateConsumersWithKafkaBindings.ftlh

I propose:
templateConsumersWithKafkaBindings.ftlh
package ${subscribePackage};

import java.util.function.Consumer;

import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
<#list subscribeMethods as method>
import ${method.classNamespace}.${method.className}<#if subscribeEntitiesSuffix?has_content>${subscribeEntitiesSuffix}</#if>;
<#if method.keyClassNamespace?has_content>
import ${method.keyClassNamespace}.${method.keyClassName};
</#if>
</#list>
import ${subscribePackage}.MessageWrapper;
import org.springframework.messaging.Message;
import org.springframework.kafka.support.KafkaHeaders;

@configuration
public class ${subscribeClassName?cap_first} {

<#list subscribeMethods as method>
private final I${method.operationId?cap_first} ${method.operationId?uncap_first};
</#list>

protected ${subscribeClassName?cap_first}(<#list subscribeMethods as method>final I${method.operationId?cap_first} ${method.operationId?uncap_first}<#sep>, </#list>) {
<#list subscribeMethods as method>
this.${method.operationId?uncap_first} = ${method.operationId?uncap_first};
</#list>
}

<#list subscribeMethods as method>
@bean
public Consumer<Message<${method.className}<#if subscribeEntitiesSuffix?has_content>${subscribeEntitiesSuffix}</#if>>> ${method.operationId?uncap_first}() {
return value -> {
final MessageWrapper messageWrapper = MessageWrapper.builder().payload(value.getPayload()).key(value.getHeaders().get(KafkaHeaders.KEY)).build();
${method.operationId?uncap_first}.${method.operationId?uncap_first}(messageWrapper);
};
}

</#list>

}

templateMessageWrapper.ftlh
package ${wrapperPackage};

import lombok.Builder;

@builder
public class MessageWrapper<T, Y> {

private T payload;

private Y key;

public MessageWrapper(final Y key, final T payload) {
this.payload = payload;
this.key = key;
}

public T getPayload() {
return payload;
}

public void setPayload(T payload) {
this.payload = payload;
}

public Y getKey() {
return key;
}

public void setKey(Y key) {
this.key = key;
}

}

interfaceConsumerWithKafkaBindings.ftlh
package ${subscribePackage};

import ${method.classNamespace}.${method.className}<#if subscribeEntitiesSuffix?has_content>${subscribeEntitiesSuffix}</#if>;
<#if method.keyClassNamespace?has_content>
import ${method.keyClassNamespace}.${method.keyClassName};
</#if>
import ${subscribePackage}.MessageWrapper;

public interface I${method.operationId?cap_first} {

void ${method.operationId?uncap_first}(final MessageWrapper<${method.className}<#if subscribeEntitiesSuffix?has_content>${subscribeEntitiesSuffix}</#if>, ${method.keyClassName}> value);
}

@github-actions
Copy link

Thank you for collaborating with the project by giving us feedback! Cheers!

@jemacineiras
Copy link
Contributor

Hi @jgonzalezlawyer,

I'll check it and prepare a fix asap.

Cheers

@jemacineiras
Copy link
Contributor

Hi @jgonzalezlawyer,
There is a possible fix in a branch linked to this issue.
Can you test it that works for you?

Cheers

jemacineiras added a commit that referenced this issue Aug 22, 2023
jemacineiras added a commit that referenced this issue Aug 22, 2023
jemacineiras added a commit that referenced this issue Aug 23, 2023
jemacineiras added a commit that referenced this issue Aug 23, 2023
jemacineiras added a commit that referenced this issue Aug 28, 2023
jemacineiras added a commit that referenced this issue Aug 28, 2023
@jemacineiras
Copy link
Contributor

Hi @jgonzalezlawyer,
There is a possible fix in a branch linked to this issue.
Can you test it that works for you?

Cheers

jemacineiras added a commit that referenced this issue Aug 30, 2023
jemacineiras added a commit that referenced this issue Aug 30, 2023
jemacineiras added a commit that referenced this issue Aug 30, 2023
jemacineiras added a commit that referenced this issue Aug 30, 2023
jemacineiras added a commit that referenced this issue Aug 30, 2023
jemacineiras added a commit that referenced this issue Aug 30, 2023
jemacineiras added a commit that referenced this issue Aug 30, 2023
jemacineiras added a commit that referenced this issue Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants