Ensure RUnlock() called directly after read to prevent deadlock withi…

…n registerValue()
snikch · May 16, 2017 · 78b9927 · 78b9927
1 parent 72cedcc
commit 78b9927
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/changes/mapper.go b/changes/mapper.go
@@ -47,10 +47,10 @@ func NewTagMapper(tags ...string) *TagMapper {
 // locations in the value's type.
 func (mapper *TagMapper) KeyIndexes(value reflect.Value) (KeyIndexes, error) {
 	mapper.RLock()
-	defer mapper.RUnlock()
-
 	typ := value.Type()
-	if indexes, ok := mapper.types[typ]; ok {
+	indexes, ok := mapper.types[typ]
+	mapper.RUnlock()
+	if ok {
 		return indexes, nil
 	}
 	return mapper.registerValue(value)