Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: #10311: Docker: ldap_client_tls.{key,cert} are located in /var/www/html/storage instead of /var/lib/snipeit/keys #10312

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

andrewshulgin
Copy link
Contributor

@andrewshulgin andrewshulgin commented Nov 13, 2021

Description

Added symlinks for ldap_client_tls.{key,cert} files in the same manner as done for oauth-private.key & oauth-public.key.

Fixes #10311

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manual testing

Test Configuration:

  • PHP version: 7.4.3
  • MySQL version: 8.0.27
  • Webserver version: Apache/2.4.41 (Ubuntu)
  • OS version: Ubuntu 20.04

Checklist:

@welcome
Copy link

welcome bot commented Nov 13, 2021

💖 Thanks for this pull request! 💖

We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already.

Examples of commit messages with semantic prefixes:

  • Fixed #<issue number>: don't overwrite prevent_default if default wasn't prevented
  • Added #<issue number>: add checkout functionality to assets
  • Improved Asset Checkout: use new notification method for checkout

Things that will help get your PR across the finish line:

  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@andrewshulgin andrewshulgin marked this pull request as ready for review November 13, 2021 01:23
@andrewshulgin andrewshulgin changed the title Docker: ldap_client_tls.{key,cert} are located in /var/www/html/storage instead of /var/lib/snipeit/keys Fixed: #10311: Docker: ldap_client_tls.{key,cert} are located in /var/www/html/storage instead of /var/lib/snipeit/keys Nov 13, 2021
@snipe snipe merged commit cf4e13f into snipe:master Nov 15, 2021
@welcome
Copy link

welcome bot commented Nov 15, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@snipe snipe added the ldap label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker: ldap_client_tls.{key,cert} are located in /var/www/html/storage instead of /var/lib/snipeit/keys
2 participants