Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Adds CodeQL to the SDLC process #10843

Merged
merged 12 commits into from
Mar 29, 2022

Conversation

ahpaleus
Copy link
Contributor

@ahpaleus ahpaleus commented Mar 21, 2022

Description

This Pull Request adds the CodeQL to the SDLC (as a GitHub Action) of the Snipe-IT project. It helps to discover vulnerabilities in the JavaScript codebase. Also, to show its potential - the pull request contains a small fix that was identified by the CodeQL (ReDoS vulnerability) in the Chart.JS library. The current configuration is to perform analysis on the master branch upon a push. The results are presented in the GitHub Advanced Security code scanning dashboard.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

It was tested on the Snipe-IT's fork (on the master branch).

Checklist:

@ahpaleus ahpaleus requested a review from snipe as a code owner March 21, 2022 09:03
@welcome
Copy link

welcome bot commented Mar 21, 2022

💖 Thanks for this pull request! 💖

We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already.

Examples of commit messages with semantic prefixes:

  • Fixed #<issue number>: don't overwrite prevent_default if default wasn't prevented
  • Added #<issue number>: add checkout functionality to assets
  • Improved Asset Checkout: use new notification method for checkout

Things that will help get your PR across the finish line:

  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@snipe
Copy link
Owner

snipe commented Mar 29, 2022

As I mentioned elsewhere, we already do a lot of these scans inside and outside of Github. I guess I'll merge this for now, but it doesn't seem needed, since we are already using code quality tooling within the SDLC.

@snipe snipe merged commit 80dff41 into snipe:develop Mar 29, 2022
@welcome
Copy link

welcome bot commented Mar 29, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@ahpaleus ahpaleus deleted the features/add_codeql_to_sdlc branch December 28, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants