Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tmp ldapauth2 #11715

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

sunflowerbofh
Copy link
Contributor

Description

This is just a slight enhancement of "Fixed #9063: Ask LDAP for user DN, don't concatenate username+baseDN." ->
#11544

Fixes #9063

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The same way as in #11544

Test Configuration:

  • PHP version: 8.1
  • MySQL version: mariadb-server-10.6
  • Webserver version: apache 2.4.54
  • OS version: Debian bookworm

Checklist:

Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exquisite. Let me test a little then I’d love to accept. Thank you!

Signed-off-by: Katharina Drexel <katharina.drexel@bfh.ch>
@snipe
Copy link
Owner

snipe commented Mar 22, 2023

@uberbrady any luck testing this? I'd love to get this merged or closed.

@snipe
Copy link
Owner

snipe commented May 10, 2023

Ping @uberbrady :)

@snipe
Copy link
Owner

snipe commented Sep 15, 2023

@uberbrady is this PR still necessary given all of the other changes we've made since it was opened?

@uberbrady
Copy link
Collaborator

@snipe I'm afraid so; I do still think it could be useful. Unfortunately my test rig still isn't quite working yet. We might need to ask @Godmartinz to test?

@snipe
Copy link
Owner

snipe commented May 29, 2024

@uberbrady re-ping on this for v7. I know the test rig is up. Can you test this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LDAP Authentication not working "Unable to validate user credentials!"
3 participants