-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Livewire slack inputs #12446
Adds Livewire slack inputs #12446
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this, @Godmartinz. I did a little cleanup here #12522. One thing I noticed is that the submit button doesn't get greyed out if the test fails. The the previous (non-livewire) version, IIRC, if the test failed, we didn't allow the form to be submitted. There are really only two scenarios where that button should be enabled:
Also the test button shouldn't appear until there are values for each field and the fields have passed the livewire validation. I'll open a SC for you. :) |
Description
Updates the Slack Settings page to use Livewire.
SlackSettingsRequest.php
since the rules have been moved over to the livewire controller.PostSlack()
method has been removed from the SettingsController.On Integration test:
on bad name of channel:
on updating the slack settings:
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: