Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes slack livewire translations, UI #12522

Merged
merged 4 commits into from
Feb 15, 2023
Merged

Conversation

snipe
Copy link
Owner

@snipe snipe commented Feb 15, 2023

This PR just implements our existing translations for Slack and cleans up the UI a bit, and makes the spinner a little bigger and makes it actually spin. :)

Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
@snipe snipe merged commit 221f5f5 into develop Feb 15, 2023
@snipe snipe deleted the fixes/slack_livewire_translations branch February 15, 2023 22:45
@what-the-diff
Copy link

what-the-diff bot commented Feb 15, 2023

  • Added translation for error message in SlackSettingsForm.php
  • Updated the slack-settings-form blade file to use bootstrap classes and added fadeIn class on alerts
  • Fixed a bug where testSlack() function was not returning anything when there is an exception thrown by GuzzleHttp\Client::post(). This caused the page to hang indefinitely after clicking Test Slack button if any of endpoint, channel or botname fields are empty (or invalid). Now it returns session flash messages as expected with appropriate translations applied from resources/lang/en/admin/settings/* files

@snipe snipe mentioned this pull request Feb 15, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant