Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix apache default page on ubuntu #5998

Merged
merged 12 commits into from
Jul 31, 2018
Merged

[WIP] Fix apache default page on ubuntu #5998

merged 12 commits into from
Jul 31, 2018

Conversation

EarlRamirez
Copy link
Contributor

On Ubuntu Apache default test page is located at /var/www/html/; however, the APP_PATH for the installation was pointing to /var/www/; therefore, after using install.sh to install Snipe-IT and the users browse to their Snipe-IT page they will go to Apache default test page.

The APP_PATH is updated to /var/www/html/; therefore, when Snipe-IT is installed using the installation script, they will be directed to the Snipe-IT preflight page and not Apache default test page.

@EarlRamirez EarlRamirez requested a review from snipe as a code owner July 30, 2018 03:42
@EarlRamirez
Copy link
Contributor Author

That did not make much of a difference, still falling back to the Apache default test page, upon further investigation, with Ubuntu 18+ the configuration file with the lowest priority e.g. 000-default.conf will always take priority; therefore, it will be better to rename the file for Ubuntu 18+ or just delete it. @snipe don't merge this PR, will update it in a couple of hours once I have a better solution for the Ubuntu 18+ folks.

@EarlRamirez EarlRamirez changed the title Fix apache default page on ubuntu [WIP] Fix apache default page on ubuntu Jul 30, 2018
@EarlRamirez
Copy link
Contributor Author

Okay tested it and the changes are good to go to be merged

@snipe snipe merged commit c2bb389 into snipe:develop Jul 31, 2018
@EarlRamirez EarlRamirez deleted the fix_apache_default_page_on_ubuntu branch September 3, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants