Skip to content

Commit

Permalink
Remove unneeded logging (#1062)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebookexperimental/Recoil#1062

Remove a log now that our question about whether this actually happens is answered. This form of logging is much more intrusive in OSS where we don't have infra to gather stats on these, but just have to spew them to the console.

Reviewed By: drarmstr

Differential Revision: D28939979

fbshipit-source-id: 465298b0bbc853b63bd8be97b47d9e222bd3b962
  • Loading branch information
davidmccabe authored and facebook-github-bot committed Jun 7, 2021
1 parent 3ab42d9 commit 7c86cea
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions src/hooks/Recoil_Hooks.js
Original file line number Diff line number Diff line change
Expand Up @@ -860,11 +860,6 @@ function useRetain_ACTUAL(toRetain: ToRetain): void {
window.clearTimeout(timeoutID.current);
timeoutID.current = null;
} else {
// Log this since it's not clear that there's any scenario where it should happen.
recoverableViolation(
'Did not retain recoil value on render, or committed after timeout elapsed. This is fine, but odd.',
'recoil',
);
for (const r of retainables) {
updateRetainCount(store, r, 1);
}
Expand Down

0 comments on commit 7c86cea

Please sign in to comment.