-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation error if expression length != message length #163
Conversation
I still need to update the approval test data. But first I need to fix another issue, which was highlighted by these test failures: in the XML or TeamCity reporters, we need to escape some of the strings before reporting them. When the resulting string is too long and truncated, there is a risk of truncating halfway through an escaped sequence, which would render the escaped string invalid. I opened the bug ticket #164 to capture this. I'm working on a solution. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
==========================================
+ Coverage 93.87% 94.05% +0.18%
==========================================
Files 27 27
Lines 1664 1698 +34
==========================================
+ Hits 1562 1597 +35
+ Misses 102 101 -1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Reported in #158. The
*REQUIRE_THAT
macros were assuming thatSNITCH_MAX_MESSAGE_LENGTH
andSNITCH_MAX_EXPR_LENGTH
were the same. If they weren't, this would cause a compilation error. The tests have now been modified so none of the lengths are identical, to catch future instances of this problem.Also fixes #164.