Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MindTagger groups tags for all extractions with the same sentence id number #44

Closed
henryre opened this issue Mar 13, 2016 · 2 comments
Closed

MindTagger groups tags for all extractions with the same sentence id number #44

henryre opened this issue Mar 13, 2016 · 2 comments
Assignees
@henryre
Labels
bug

Comments

@henryre
Copy link
Member

henryre commented Mar 13, 2016

Should give each extraction a unique id
@henryre henryre added the bug label Mar 13, 2016
@ajratner
Copy link
Contributor

Yup good call, we should definitely do this. In general we should
delineate a clear id value which always corresponds to the Extraction
objects

On Sun, Mar 13, 2016 at 1:41 PM Henry Ehrenberg notifications@github.com
wrote:

Should give each extraction a unique id

—
Reply to this email directly or view it on GitHub
#44.

@henryre
Copy link
Member Author

henryre commented Mar 13, 2016

Agreed. I was going to fix this and clean everything up using a proxy pattern with the Extraction objects.

@henryre henryre mentioned this issue Mar 14, 2016
Closed
@henryre henryre self-assigned this Mar 14, 2016
@henryre henryre mentioned this issue Mar 14, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henryre henryre

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ajratner @henryre